Re: [PATCH 3/6] powerpc: add memory map support to Freescale RapidIO block
- From
- Andrew Morton <akpm@linux-foundation.org>
- Date
- 2009-05-12 22:11:22
- Also in
- linuxppc-dev, lkml
- Reply to
- Li Yang, 2009-05-12
On Tue, 12 May 2009 16:36:00 +0800 Li Yang [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+ align = (size < 0x1000) ? 0x1000 : 1 << (__ilog2(size - 1) + 1); + + /* Align the size */ + if ((lstart + size) > (_ALIGN_DOWN(lstart, align) + align)) {
__ilog2() and _ALIGN_DOWN() are powerpc-specific functions. It would
be preferable to use more general helpers if possible. ALIGN() and ilog2()
might suit here.