Re: [PATCH 5/6]: nl80211: Eliminate reference to BUS_ID_SIZE.
From: David Miller <davem@davemloft.net>
Date: 2009-05-28 08:08:31
From: David Miller <davem@davemloft.net>
Date: 2009-05-28 08:08:31
From: Marcel Holtmann <marcel@holtmann.org> Date: Thu, 28 May 2009 09:27:23 +0200
quoted
@@ -57,7 +57,7 @@ static int get_drv_dev_by_info_ifindex(struct nlattr **attrs, static struct nla_policy nl80211_policy[NL80211_ATTR_MAX+1] __read_mostly = { [NL80211_ATTR_WIPHY] = { .type = NLA_U32 }, [NL80211_ATTR_WIPHY_NAME] = { .type = NLA_NUL_STRING, - .len = BUS_ID_SIZE-1 }, + .len = 20-1 }, [NL80211_ATTR_WIPHY_TXQ_PARAMS] = { .type = NLA_NESTED }, [NL80211_ATTR_WIPHY_FREQ] = { .type = NLA_U32 }, [NL80211_ATTR_WIPHY_CHANNEL_TYPE] = { .type = NLA_U32 },this patch is actually wrong.
It cannot be right or wrong, it is merely replacing an existing value with the constant equivalent. It is a change which does absolutely nothing.
You should remove the .len value all together since the phy name has no limit anymore and so shouldn't the netlink API.
Anyone is free to make that improvement. But that's now what I am trying to accomplish here.