Re: tcp vegas ssthresh bugfix
From: David Miller <davem@davemloft.net>
Date: 2009-05-19 09:48:36
From: Douglas Leith <redacted> Date: Tue, 19 May 2009 10:22:07 +0100
This patch fixes a minor bug in tcp_vegas.c which affects ssthresh accounting when vegas congestion control decreases snd_cwnd. Signed-off-by: Doug Leith <redacted>
This patch has several problems:
quoted hunk
--- net/ipv4/tcp_vegas.c.orig 2009-04-27 12:55:18.000000000 +0100 +++ net/ipv4/tcp_vegas.c 2009-05-19 09:25:17.000000000 +0100
The patch should be "-p1" based, one directory higher up. You have it "-p0" based.
+ /* Update ssthresh to reflect + * decreased cwnd */
This is not the correct way to format a comment in the Linux kernel, the correct layout is: /* Update ssthresh to reflect * decreased cwnd. */ Please fix these problems up and resubmit.