Thread (7 messages) 7 messages, 2 authors, 2009-05-03

Re: [PATCH] powerpc: convert mace to netdev_ops

From: David Miller <davem@davemloft.net>
Date: 2009-04-27 12:43:22
Also in: linuxppc-dev, lkml

From: Rogério Brito <redacted>
Date: Mon, 27 Apr 2009 09:16:33 -0300
Is this anything close to what needs to be done? It's not without
failures, because the function mace_set_timeout receives a pointer to a
struct net_device, but is marked inline and is used by mace_tx_timeout,
which receives an unsigned long (which calls mace_set_timeout).

Perhaps it would be a case of removing the inline hint to the compiler?
I guess that BenH or Paul could comment here better...

Signed-off-by: Rogério Brito <redacted>
You can fix the mace_set_timeout() function arguments by having
a helper function that simply wraps around it and provides the
second expection of argument types.

Your patch is also wrong, it's missing a lot of netdev_ops
entries that are implicitly obtained via alloc_etherdev(),
namely:

	.ndo_change_mtu		= eth_change_mtu,
	.ndo_set_mac_address 	= eth_mac_addr,
	.ndo_validate_addr	= eth_validate_addr,
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help