Re: [PATCH] netfilter: use per-cpu spinlock rather than RCU (v3)
From: Patrick McHardy <hidden>
Date: 2009-04-16 12:28:28
Also in:
lkml, netfilter-devel
From: Patrick McHardy <hidden>
Date: 2009-04-16 12:28:28
Also in:
lkml, netfilter-devel
David Miller wrote:
From: Stephen Hemminger <redacted> Date: Wed, 15 Apr 2009 17:01:11 -0700quoted
The counters are the bigger problem, otherwise we could just free table info via rcu. Do we really have to support: replace where the counter values coming out to user space are always exactly accurate, or is it allowed to replace a rule and maybe lose some counter ticks (worst case NCPU-1).I say this case doesn't matter until someone can prove that it's any different from the IPTABLES replace operation system call executing a few microseconds earlier or later. There really is no difference, and we're making complexity out of nothing just to ensure something which isn't actually guarenteed right now.
Actually I believe it does work right now. Userspace maps the old counter values to the replacement rules and the kernel adds them up, so in the end we currently should always have accurate counters, independant of the exact time when a replacement took place.