Thread (1 message) 1 message, 1 author, 2009-04-08

Re: [PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module_task()

From: Brandeburg, Jesse <hidden>
Date: 2009-04-08 17:52:25
Also in: lkml

Tony Breeds wrote:
quoted hunk
GCC warns:
drivers/net/ixgbe/ixgbe_main.c: In function
'ixgbe_sfp_config_module_task': 
drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parentheses
around operand of '!' or change '&' to '&&' or '!' to '~' 

Which I think is right.  Bracket to remove ambiguity.

Signed-off-by: Tony Breeds <redacted>
---
 drivers/net/ixgbe/ixgbe_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_main.c
b/drivers/net/ixgbe/ixgbe_main.c 
index 9ef128a..9099634 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -3917,7 +3917,7 @@ static void ixgbe_sfp_config_module_task(struct
 	work_struct *work) }
 	hw->mac.ops.setup_sfp(hw);

-	if (!adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK)
+	if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK))
 		/* This will also work for DA Twinax connections */
 		schedule_work(&adapter->multispeed_fiber_task);
 	adapter->flags &= ~IXGBE_FLAG_IN_SFP_MOD_TASK;
you're extremely correct, thanks!

Acked-by: Jesse Brandeburg <redacted>
------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help