Am Mittwoch 01 April 2009 00:10:28 schrieb David Miller:

quoted

Here you enable interrupts. Are you sure ndo_start_xmit is never
called with interrupts disabled?

It must never be invoked that way, this would break so many
drivers.

On the other hand, all of these driver paths never execute
in a real hardware interrupt context, the deepest it gets
into is software interrupts.  So spin_*lock*_bh() might be
more appropriate.

Thanks. The patch is good. I'll check the other USB network
drivers.

	Regards
		Oliver