Re: [PATCH] igb: fix kexec with igb
From: Yinghai Lu <yinghai@kernel.org>
Date: 2009-03-07 07:31:32
Also in:
lkml
On Fri, Mar 6, 2009 at 11:18 PM, Jesse Brandeburg [off-list ref] wrote:
On Fri, Mar 6, 2009 at 8:33 PM, Yinghai Lu [off-list ref] wrote:quoted
Impact: could probe igb Found one system with 82575EB, in the kernel that is kexeced, probe igb failed with -2. it looks like the same behavior happened on forcedeth. try to check system_state to make sure if put it on D3 Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- drivers/net/igb/igb_main.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-)I see the point of the patch, but I know for a fact that ixgbe when enabled for MSI-X also doesn't work with kexec. so my questions are: are you going to change every driver?
i tend to only change driver that i have related HW.
why can't this be fixed in core kernel code instead?
will check it.
Shouldn't pci_enable_device take it out of D3? Or maybe it should be taken out of D3 immediately if someone tries to ioremap any of the BARx registers?
looks like second kernel can not detect the state any more. YH