Thread (29 messages) 29 messages, 5 authors, 2009-03-05

Re: [BUG] 2.6.29-rc* QinQ vlan trunking regression

From: Patrick McHardy <hidden>
Date: 2009-03-05 05:51:43
Also in: lkml

David Miller wrote:
From: Patrick McHardy <redacted>
Date: Wed, 04 Mar 2009 12:45:33 +0100
quoted
This is a bit tricky to fix since we actually need some valid
ops before invoking ->init(). One way would be to move the compat
ops initialization to a seperate function and have VLAN use it to
switch its ops.
Mind if I push this into net-2.6?

vlan: Fix vlan-in-vlan crashes.

As analyzed by Patrick McHardy, vlan needs to reset it's
netdev_ops pointer in it's ->init() function but this
leaves the compat method pointers stale.

Add a netdev_resync_ops() and call it from the vlan code.
This looks fine, thanks. Even if it doesn't fix this particular
report, I think its appropriate for net-2.6.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help