Thread (1 message) 1 message, 1 author, 2009-03-16

Re: [PATCH 5/7] tcp: simplify tcp_current_mss

From: David Miller <davem@davemloft.net>
Date: 2009-03-16 03:11:07

From: "Ilpo Järvinen" <redacted>
Date: Sun, 15 Mar 2009 02:07:53 +0200
There's very little need for most of the callsites to get
tp->xmit_goal_size updated. That will cost us divide as is,
so slice the function in two. Also, the only users of the
tp->xmit_goal_size are directly behind tcp_current_mss(),
so there's no need to store that variable into tcp_sock
at all! The drop of xmit_goal_size currently leaves 16-bit
hole and some reorganization would again be necessary to
change that (but I'm aiming to fill that hole with u16
xmit_goal_size_segs to cache the results of the remaining
divide to get that tso on regression).

Bring xmit_goal_size parts into tcp.c

Signed-off-by: Ilpo Järvinen <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help