Re: [PATCH 1/7] tcp: remove pointless .dsack/.num_sacks code

From: "Ilpo Järvinen" <redacted>
Date: Sun, 15 Mar 2009 02:07:49 +0200

In the pure assignment case, the earlier zeroing is
still in effect.

David S. Miller raised concerns if the ifs are there to avoid
dirtying cachelines. I came to these conclusions:

quoted

We'll be dirty it anyway (now that I check), the first "real" statement
in tcp_rcv_established is:

      tp->rx_opt.saw_tstamp = 0;

...that'll land on the same dword. :-/

I suppose the blocks are there just because they had more complexity
inside when they had to calculate the eff_sacks too (maybe it would
have been better to just remove them in that drop-patch so you would
have had less head-ache :-)).

Signed-off-by: Ilpo Järvinen <redacted>

Applied.