Thread (12 messages) flat view 12 messages, 5 authors, 2009-04-21

Re: 3c59x: shared interrupt problem

From: Steffen Klassert <hidden>
Date: 2009-03-14 14:08:44

On Fri, Mar 13, 2009 at 03:51:16PM -0700, David Miller wrote:
quoted
#### ChangeSet ####
2003-05-19 10:27:49-07:00, akpm@digeo.com 
  [PATCH] 3c59x irqreturn fix
  
  Apparently boomerang_interrupt() is generating lots of "nobody cared"
  warnings - one per packet it seems.  Frankly, I don't have a clue why.
  
  These are ancient cards and the driver is otherwise stable, so just
  change it to return IRQ_HANDLED and move on...
So basically it's a band-aid because we didn't investigate why
this happens.

I think we should put the change in, and then look into things
properly if users report this issue again.
Gerhard reported at least one of these "nobody cared" messages at shutdown
after applying this change. He wanted to provide us with further informations
about this issue next week. Best would be to put it in together with a fix.
So I would suggest to wait, perhaps we can fix it with his informations. 

The code there right now is just completely wrong when the
3c59x interrupt is shared with another device.
Indeed.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help