Thread (10 messages) 10 messages, 2 authors, 2009-02-27
STALE6312d

[PATCH 3/8] appletalk: fix warning: format not a string literal and no ...

From: Hannes Eder <hidden>
Date: 2009-02-25 20:40:00
Also in: kernel-janitors, lkml
Subsystem: appletalk network layer, networking [general], the rest · Maintainers: "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

Impact: Use 'static const char[]' instead of 'static char[]', and
since the data is const now it can be placed in __initconst.

Fix this warning:
  net/appletalk/ddp.c: In function 'atalk_init':
  net/appletalk/ddp.c:1894: warning: format not a string literal and no format arguments

Signed-off-by: Hannes Eder <redacted>
---
 net/appletalk/ddp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index 510a678..cf05c43 100644
--- a/net/appletalk/ddp.c
+++ b/net/appletalk/ddp.c
@@ -1877,7 +1877,7 @@ EXPORT_SYMBOL(aarp_send_ddp);
 EXPORT_SYMBOL(atrtr_get_dev);
 EXPORT_SYMBOL(atalk_find_dev_addr);
 
-static char atalk_err_snap[] __initdata =
+static const char atalk_err_snap[] __initconst =
 	KERN_CRIT "Unable to register DDP with SNAP.\n";
 
 /* Called by proto.c on kernel start up */
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help