Thread (1 message) 1 message, 1 author, 2009-02-14

[patch 46/48] netfilter: xt_sctp: sctp chunk mapping doesnt work

DORMANTno replies

From: Greg KH <gregkh@suse.de>
Date: 2009-02-14 01:47:06
Also in: lkml, netfilter-devel

2.6.28-stable review patch.  If anyone has any objections, please let us know.

------------------

From: Qu Haoran <redacted>

netfilter: xt_sctp: sctp chunk mapping doesn't work

Upstream commit: d4e2675a

When user tries to map all chunks given in argument, kernel
works on a copy of the chunkmap, but at the end it doesn't
check the copy, but the orginal one.

Signed-off-by: Qu Haoran <redacted>
Signed-off-by: Nicolas Dichtel <redacted>
Signed-off-by: Patrick McHardy <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 net/netfilter/xt_sctp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/netfilter/xt_sctp.c
+++ b/net/netfilter/xt_sctp.c
@@ -105,7 +105,7 @@ match_packet(const struct sk_buff *skb,
 
 	switch (chunk_match_type) {
 	case SCTP_CHUNK_MATCH_ALL:
-		return SCTP_CHUNKMAP_IS_CLEAR(info->chunkmap);
+		return SCTP_CHUNKMAP_IS_CLEAR(chunkmapcopy);
 	case SCTP_CHUNK_MATCH_ANY:
 		return false;
 	case SCTP_CHUNK_MATCH_ONLY:
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help