Re: [PATCH] sfc: mdio_clause45_read errors go unnoticed
From: Ben Hutchings <hidden>
Date: 2009-02-27 16:45:31
From: Ben Hutchings <hidden>
Date: 2009-02-27 16:45:31
On Fri, 2009-02-27 at 17:31 +0100, Roel Kluin wrote:
This patch was not tested in any way, but: since commit 27dd2caca4eabe7c13a052b7456495ba75535e6a ------------------------------>8-------------8<--------------------------------- mdio_clause45_read may return -ERR, but since 'devices' is unsigned, this is not noticed.
I already submitted a fix for this. I do need to resubmit it for net-next-2.6 though. Thanks for the reminder. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.