Re: [PATCH 2/2] veth: Configurable nterface MTU
From: Eric W. Biederman <hidden>
Date: 2009-02-27 12:41:16
From: Eric W. Biederman <hidden>
Date: 2009-02-27 12:41:16
David Miller [off-list ref] writes:
From: ebiederm@xmission.com (Eric W. Biederman) Date: Wed, 25 Feb 2009 21:49:04 -0800quoted
@@ -249,6 +253,19 @@ static int veth_close(struct net_device *dev) return 0; } +static int is_valid_veth_mtu(int new_mtu) +{ + return (new_mtu >= MIN_MTU && new_mtu <= MAX_MTU); +} + +static int veth_change_mtu(struct net_device *dev, int new_mtu) +{ + if (is_valid_veth_mtu(new_mtu)) + return -EINVAL; + dev->mtu = new_mtu; + return 0; +} +This validity test seems to be reversed?
Crap. You are correct. I will respin. Eric