Re: Kernel problem
From: David Miller <davem@davemloft.net>
Date: 2009-02-27 08:59:23
From: David Miller <davem@davemloft.net>
Date: 2009-02-27 08:59:23
From: Jarek Poplawski <redacted> Date: Fri, 27 Feb 2009 08:41:10 +0000
Probably I miss something, but I'm not sure it's really necessary in all (non-VLAN) entry points. Of course it's an optimization to drop these things early, but there is a lot off mess with replicating various parts of netif_receive_skb() in so many places. As a matter of fact, I wonder why it can't be done in one place, e.g. netif_nit_deliver(), which was created partly for similar problems.
I think we do need to hit all possible entry points. How would you be able to handle it in netif_nit_deliver()? Functions like netif_receive_skb() open-code the delivery to network taps, they don't actually call netif_receive_skb().