RE: [net-next PATCH 1/2] ixgbe: Move ring features into an enum, allowing easier future maintenance

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net] 
Sent: Tuesday, February 24, 2009 4:37 PM
To: Kirsher, Jeffrey T
Cc: netdev@vger.kernel.org; gospo@redhat.com; Waskiewicz Jr, Peter P
Subject: Re: [net-next PATCH 1/2] ixgbe: Move ring features 
into an enum, allowing easier future maintenance

From: Jeff Kirsher <redacted>
Date: Tue, 24 Feb 2009 15:40:37 -0800

quoted

From: Shannon Nelson <redacted>

The ring_feature member of ixgbe_adapter is statically 

allocated based on

quoted

the supported features of the device.  When a new feature is 

added, we need

quoted

to manually update the static allocation.  This patch makes 

the feature

quoted

list an enum, eliminating the need for multiple updates to 

the code when

quoted

adding a new feature.

Signed-off-by: Peter P Waskiewicz Jr 

[off-list ref]

quoted

Signed-off-by: Jeff Kirsher <redacted>

Applied.

I would appreciate it if, in the future, Shannon would signoff his
patches :-)

Perhaps a little after the fact, but does this help?  I didn't expect to get credit - they haven't given me credit for my other little tweaks.  Usually I get to remain anonymous...

Signed-off-by: Shannon Nelson <redacted>