Thread (87 messages) 87 messages, 12 authors, 2009-04-06

Re: [PATCH] iptables: xt_hashlimit fix

From: Jan Engelhardt <hidden>
Date: 2009-02-20 18:33:43
Also in: netfilter-devel

On Friday 2009-02-20 19:10, Eric Dumazet wrote:
Damned this broke xt_hashlimit, version=0
Look file "net/netfilter/xt_hashlimit.c" line 706

   /* Ugly hack: For SMP, we only want to use one set */
   r->u.master = r;

So, it appears some modules are using pointers to themselves, what a hack :(
We probably need an audit of other modules.
xt_limit and xt_statistic are affected; I'll happily fix that up.
Commit 784544739a25c30637397ace5489eeb6e15d7d49
(netfilter: iptables: lock free counters) broke xt_hashlimit netfilter module :

This module was storing a pointer inside its xt_hashlimit_info, and 
this pointer is not relocated when we temporarly switch tables 
(iptables -L).
Patch ok.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help