Re: LRO restructuring?

On Thu, Feb 19, 2009 at 02:17:11PM -0800, James Huang wrote:

Hi all,

    One question about inet_lro.c (linux 2.6.28.6)
In lro_proc_segment(), it does not check the number of available frags
entries in lro_desc->parent against the number of new fragments to be added
before calling lro_add_frags().  Is that a bug?  I see that
lro_proc_segment() does some type of checking at the end, but could that be
too late (i.e. overflow the frags[])??

    Also I think some obvious optimization in lro_get_desc() can be done by
combining the two for loops into one.

That file is obsolete.  The GRO code that will replace it lives
in various places:

	net/core/dev.c
	net/core/skbuff.c
	net/ipv4/af_inet.c
	net/ipv6/af_inet6.c
	net/ipv4/tcp_ipv4.c
	net/ipv6/tcp_ipv6.c
	net/ipv4/tcp.c
	net/8021q/vlan_core.c

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt