Re: [PATCH] net/sunrpc/xprtsock.c: some common code found

On Tue, Feb 10, 2009 at 03:20:36PM +0200, Ilpo Järvinen wrote:

On Sun, 8 Feb 2009, J. Bruce Fields wrote:

quoted

(Where's diff-func from?)

My own tool collection. I can make it available if you want to.

Sure, I'd be curious.

--b.

quoted

In similar cases in the future, if you want to cater to the more tired
and/or mentally challenged among us (which may just be me), some clue
that visually distinguishes the quoted diff output in the comment might
help; e.g., maybe indent it like the below.

(But that's intended as a suggestion, not a requirement.)

Yeah, a good idea... I'll sed some spaces in front of them in the future 
to make the difference more obvious. The expected outcome though is that 
somebody probably then hits reply button too soon claiming that the patch 
is broken :-).


-- 
 i.