Re: Deadlock with icmpv6fuzz
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2009-02-09 05:04:09
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2009-02-09 05:04:09
David Miller [off-list ref] wrote:
But some apps might start breaking since this would now charge the socket and we could hit the limits whereas before we wouldn't.
Yes we should definitely test this carefully. However, I think it is the right thing to do since we shouldn't leave holes where the user can allocate kernel memory that is uncapped. In fact, a number of spots in IPv6 already use sock_kmalloc for these objects anyway (e.g., ipv6_dup_options in exthdrs.c) so there is no fundamental reason why this limit can't be imposed. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt