Re: [PATCH] net/sunrpc/xprtsock.c: some common code found

On Sat, Feb 07, 2009 at 06:56:03PM +0200, Ilpo Järvinen wrote:

I personally think that people were honestly just mislead to think that
diff-funcs output is part of the patch

Yes, exactly, in my case, that's all it was--the "diff" I thought I saw
in my 2-second skim looked odd, and I figured a comment might have
gotten dropped off in the process of replying and adding cc's--hence the
original question.

Anyway, the patch looks obviously fine to me, and the diff-func and
codiff output are helpful.  (Where's diff-func from?)

In similar cases in the future, if you want to cater to the more tired
and/or mentally challenged among us (which may just be me), some clue
that visually distinguishes the quoted diff output in the comment might
help; e.g., maybe indent it like the below.

(But that's intended as a suggestion, not a requirement.)

--b.

Subject: Re: [PATCH] net/sunrpc/xprtsock.c: some common code found

diff-func output suggests these functions are very similar:

	$ diff-funcs xs_udp_write_space net/sunrpc/xprtsock.c
	 ...(etc)

and codiff shows the space savings:

	$ codiff net/sunrpc/xprtsock.o net/sunrpc/xprtsock.o.new
	...(etc)

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen-pxSi+dnQzZMxHbG02/KK1g@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html