Re: [PATCH v3 1/4] virtio_net: Add a virtqueue for outbound control commands
From: Rusty Russell <hidden>
Date: 2009-02-02 09:40:58
Also in:
kvm
On Monday 02 February 2009 06:35:10 Alex Williamson wrote:
+static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd,
+ struct scatterlist data[], int out, int in)
+{
+ struct scatterlist sg[VIRTIO_NET_MAX_CTRL_ARGS];...
quoted hunk ↗ jump to hunk
diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h index f76bd4a..f28a72a 100644 --- a/include/linux/virtio_net.h +++ b/include/linux/virtio_net.h
...
+#define VIRTIO_NET_MAX_CTRL_ARGS 2
I think this definition belongs at the top of virtio_net.c; the others are userspace-exposed, this is really an internal issue, no? Other than that, you can add Acked-by: Rusty Russell [off-list ref] and send to netdev for DaveM's tree. Thanks! Rusty.