Re: [PATCH] phylib: Fix oops in suspend/resume paths
From: David Miller <davem@davemloft.net>
Date: 2009-01-22 21:51:54
Also in:
linuxppc-dev
From: David Miller <davem@davemloft.net>
Date: 2009-01-22 21:51:54
Also in:
linuxppc-dev
From: Anton Vorontsov <redacted> Date: Thu, 22 Jan 2009 21:09:30 +0300
Suspend/resume routines check for phydrv != NULL, but that is wrong because "phydrv" comes from container_of(drv). If drv is NULL, then container_of(drv) will return non-NULL result, and the checks won't work. The Freescale TBI PHYs are driver-less, so "drv" is NULL, and that leads to the following oops:
...
This patch fixes the issue, plus removes unneeded parentheses and fixes indentation level in mdio_bus_suspend(). Signed-off-by: Anton Vorontsov <redacted>
Applied, thanks Anton.