Re: [PATCH] phylib: Fix Freescale TBI PHY detection

From: Andy Fleming <redacted>
Date: Wed, 14 Jan 2009 12:20:35 -0600

On Jan 14, 2009, at 9:03 AM, Anton Vorontsov wrote:

quoted

quoted

There is one thing I don't actually understand though...

Andy, were you testing the TBI support on a hardware where PHY ID
!= 0x0 or maybe your TBI PHY support patch (commit b31a1d8b41513b,
dated Tue Dec 16 15:29:15 2008) was based on a bit outdated kernel
version? Because according to the git timestamps, the TBI support
was not working since the submission.

Just in case, the hardware I'm seeing the PHY ID == 0x0 is
MPC8378E-MDS.

I think I got it. Probably the TBI support patch was based on the
powerpc.git next, and the commit that broke the TBI support
was in the net-next-2.6 tree.

That explains why nobody noticed the issue.

Yeah, I dropped the ball.  I saw the patch go in, thought that might break something, but I didn't find time to look into it.  Thanks for finding and reverting this bug.

Acked-by: Andy Fleming <redacted>

Patch applied, thanks everyone.

I was worried when I applied the patch causing this, that some
device would in fact trigger that specific test.  Turns out
my worries were warranted :)