Thread (1 message) 1 message, 1 author, 2009-01-23
STALE6431d

[patch 29/46] netfilter: ebtables: fix inversion in match code

From: Greg KH <gregkh@suse.de>
Date: 2009-01-23 01:24:53
Also in: lkml, netfilter-devel

2.6.28-stable review patch.  If anyone has any objections, please let us know.

------------------

From: Patrick McHardy <redacted>

Upstream commit d61ba9f:

Commit 8cc784ee (netfilter: change return types of match functions
for ebtables extensions) broke ebtables matches by inverting the
sense of match/nomatch.

Reported-by: Matt Cross <redacted>
Signed-off-by: Jan Engelhardt <redacted>
Signed-off-by: Patrick McHardy <redacted>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 net/bridge/netfilter/ebtables.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/bridge/netfilter/ebtables.c
+++ b/net/bridge/netfilter/ebtables.c
@@ -80,7 +80,7 @@ static inline int ebt_do_match (struct e
 {
 	par->match     = m->u.match;
 	par->matchinfo = m->data;
-	return m->u.match->match(skb, par);
+	return m->u.match->match(skb, par) ? EBT_MATCH : EBT_NOMATCH;
 }
 
 static inline int ebt_dev_check(char *entry, const struct net_device *device)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help