On Wed, Jan 14, 2009 at 10:06 PM, Geert Uytterhoeven
[off-list ref] wrote:
What Sam means is that the warnings about externs not making sense in userspace
are indicators that there may be other external declarations (without "extern")
in those files, and that you should fix those at the same time (i.e. either
don't fix any of them, or fix all of them (in the same file)). If you don't
fix them at the same time, people tend to forget about them.
So the warnings are just considered canaries in our coal mine. Killing only the
canaries doesn't help.
If this is the case, then drop extern patches and let maintainers of
those files should handle them then they will not forget and never
repeat this mistake again.
--
JSR