Re: 2.6.28-git8: tg3 doesn't work due to firmware not loading (-git7 is ok)
From: David Woodhouse <dwmw2@infradead.org>
Date: 2009-01-12 08:14:22
Also in:
lkml
On Sun, 2009-01-11 at 19:10 -0500, Valdis.Kletnieks@vt.edu wrote:
So it looks like the patch is failing to finish initialization of the card. Damned if *I* can see what's breaking it, the conversion to use a helper function tg3_request_firmware seems sane enough....
Ahem...
--- drivers/net/tg3.c.stupiddwmw2 2009-01-12 08:13:05.000000000 +0000
+++ drivers/net/tg3.c 2009-01-12 08:13:09.000000000 +0000@@ -13151,7 +13151,7 @@ static int __devinit tg3_init_one(struct try again in tg3_open(). So if you have the driver built into the kernel, you can still get the firmware loaded after userspace is running, when the device comes up. */ - if (err != -ENOENT) + if (err && err != -ENOENT) goto err_out_fw; }
--
dwmw2