Thread (10 messages) 10 messages, 3 authors, 2009-01-08

Re: [PATCH 1/4] wimax: fix '#ifndef CONFIG_BUG' layout to avoid warning

flat view

From: David Miller <davem@davemloft.net>
Date: 2009-01-08 19:07:22
Also in: linux-next, lkml

From: Inaky Perez-Gonzalez <redacted>
Date: Wed,  7 Jan 2009 11:22:19 -0800
Reported by Randy Dunlap:
quoted
Also, this warning needs to be fixed:

linux-next-20090106/net/wimax/id-table.c:133: warning: ISO C90
forbids mixed declarations and code
Move the return on #defined(CONFIG_BUG) below the variable
declarations so it doesn't violate ISO C90.

On wimax_id_table_release() we want to do a debug check if CONFIG_BUG
is enabled. However, we also want the debug code to be always compiled
to ensure there is no bitrot. It will be optimized out by the compiler
when CONFIG_BUG is disabled.

Added a note to the function header stating this.

Signed-off-by: Inaky Perez-Gonzalez <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help