From: Ben Hutchings <redacted>
Date: Sat, 31 Jan 2009 00:04:15 +0000

On Fri, 2009-01-30 at 14:09 -0800, David Miller wrote:

quoted

From: Ben Hutchings <redacted>
Date: Fri, 30 Jan 2009 03:48:10 +0000

quoted

From: Steve Hodgson <redacted>

Enable a firmware option that appears to be necessary for reliable
operation.

Signed-off-by: Ben Hutchings <redacted>

I applied all of these patches but:

1) When you get changes written by other people, such as
   Steve Hodgson here and in the next few patches, you need
   to get Signed-off-by lines from them too.

I have been attributing changes to my colleagues for some time and never
heard this.  In any case the copyright lies with my employer and I am
authorised to release these changes; isn't that what my initial sign-
off means?

Sure, but it is even more meaningful if the person who actually
wrote the changes signs off on it too.

quoted

2) Outside of the merge window I do not want to see totally
   irrelevant stuff like PHY loopback fixes.

   Those kinds of fixes are totally inappropriate at this time.

Are you saying that a spurious self-test failure is not a serious bug?

Normal users will not run the self-test giblet, and it has
not been reported as a 2.6.29 regression on lkml.