Re: [PATCH] smsc911x: timeout reaches -1
From: <hidden>
Date: 2009-01-29 15:23:57
Roel Kluin [off-list ref] wrote on 29/01/2009 15:12:03:
quoted hunk ↗ jump to hunk
With a postfix decrement the timeout will reach -1 rather than 0, so the warning will not be issued. Signed-off-by: Roel Kluin <redacted> ---diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c index f513bdf..783c1a7 100644 --- a/drivers/net/smsc911x.c +++ b/drivers/net/smsc911x.c@@ -953,7 +953,7 @@ smsc911x_rx_fastforward(struct smsc911x_data*pdata, unsigned int pktbytes) do { udelay(1); val = smsc911x_reg_read(pdata, RX_DP_CTRL); - } while (timeout-- && (val & RX_DP_CTRL_RX_FFWD_)); + } while (--timeout && (val & RX_DP_CTRL_RX_FFWD_)); if (unlikely(timeout == 0)) SMSC_WARNING(HW, "Timed out waiting for "
Thanks for spotting this Roel. Acked-by: Steve Glendinning <redacted>