On Tue, Jan 27, 2009 at 5:18 AM, Evgeniy Polyakov [off-list ref] wrote:

On Mon, Jan 26, 2009 at 06:17:41PM -0800, Andy Grover (andy.grover@oracle.com) wrote:

quoted

+static LIST_HEAD(transports);
+static DECLARE_RWSEM(trans_sem);
+

RDS_ prefix?

Even needed for statics?

quoted

+int rds_trans_register(struct rds_transport *trans)
+{
+     BUG_ON(strlen(trans->t_name) + 1 >
+            sizeof(((struct rds_info_connection *)0)->transport));
+

Wow. Why not declare 15 as some constant and put it into rds_transport
structure definition?

Makes sense.

quoted

+        if (IN_LOOPBACK(ntohl(addr)))
+                return &rds_loop_transport;
+

Tabs have run away.

Will fix. Thanks.

Regards -- Andy