Thread (23 messages) flat view 23 messages, 8 authors, 2009-01-26

Re: [PATCH 7/8] arm: convert omap ldp platform to use smsc911x

From: stanley.miao <hidden>
Date: 2009-01-24 04:05:29

On Thu, 2009-01-22 at 10:58 +0000, Russell King - ARM Linux wrote:
On Wed, Jan 21, 2009 at 11:06:09AM +0800, Stanley.Miao wrote:
quoted
-	ldp_smc911x_resources[0].start = cs_mem_base + 0x0;
-	ldp_smc911x_resources[0].end   = cs_mem_base + 0xf;
+	ldp_smsc911x_resources[0].start = cs_mem_base + 0x0;
+	ldp_smsc911x_resources[0].end   = cs_mem_base + 0x100;
This doesn't look right - 'end' is inclusive not exclusive.  So this
reserves 257 bytes, not 256 bytes.
Thanks for the review, correct it.

Stanley.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help