Re: [PATCH REPOST 0/5] convert arm platforms to smsc911x

Russell King - ARM Linux [off-list ref] wrote on 19/01/2009 
09:22:57:

On Mon, Jan 19, 2009 at 04:04:34PM +0800, stanley.miao wrote:

quoted

On Sun, 2009-01-18 at 21:53 -0800, David Miller wrote:

quoted

I've applied patches 1 and 2, the smsc911x driver changes.

I can pull the platform changes into net-next-2.6 as well
if people don't think there will enough conflicts to cause
problems.

I think  the platform data had better stay in arm tree.

What would be the impact if patches 3 to 5 got merged before 1 and 2?

It would not break compilation, but it would probably break ethernet 
support
on those three platforms.

All 3 platforms pass some combination of IRQF_TRIGGER_LOW | IRQF_SHARED 
when
registering these interrupts.  The trigger flag isn't passed through 
without
1 and IRQF_SHARED isn't specified without 2.

I expect register_irq would fail on these platforms without these flags?

Steve