Re: [PATCH] fec: do not use memcpy on physical addresses
From: Greg Ungerer <hidden>
Date: 2009-01-15 03:55:46
Hi Sacha, Sascha Hauer wrote:
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> ---
Also fine for ColdFire. Acked-by: Greg Ungerer <redacted>
quoted hunk ↗ jump to hunk
drivers/net/fec.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/drivers/net/fec.c b/drivers/net/fec.c index 1a07d56..29df0df 100644 --- a/drivers/net/fec.c +++ b/drivers/net/fec.c@@ -339,7 +339,7 @@ fec_enet_start_xmit(struct sk_buff *skb, struct net_device *dev) if (bdp->cbd_bufaddr & 0x3) { unsigned int index; index = bdp - fep->tx_bd_base; - memcpy(fep->tx_bounce[index], (void *) bdp->cbd_bufaddr, bdp->cbd_datlen); + memcpy(fep->tx_bounce[index], (void *)skb->data, skb->len); bdp->cbd_bufaddr = __pa(fep->tx_bounce[index]); }
-- ------------------------------------------------------------------------ Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com SnapGear, a McAfee Company PHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com