Re: [PATCH 7/6] Re: [PATCH 2/6] pkt_sched: sch_htb: Consider used jiffies in htb_dequeue()
From: Patrick McHardy <hidden>
Date: 2009-01-12 13:10:55
From: Patrick McHardy <hidden>
Date: 2009-01-12 13:10:55
Jarek Poplawski wrote:
On Mon, Jan 12, 2009 at 11:22:47AM +0100, Patrick McHardy wrote: ...quoted
It doesn't bother me :) I just think its the technical better and also most likely code-wise cleaner solution to this problem. Cancellation wouldn't be necessary since an unnecessary netif_schedule() doesn't really matter.Hmm... Do you mean during destroying... It's probably not very long, but deleting and creating qdiscs especially for some virtual devices can take longer I guess.
I was referring to your statement "but also some overhead when cancelling this workqueue" and assumed you meant during packet processing. In the destruction path it really doesn't matter at all.