Re: [PATCH 5/5] Phonet: USB CDC Phonet function for gadget framework
From: Marcel Holtmann <marcel@holtmann.org>
Date: 2009-01-08 17:15:07
Hi Remi,
quoted
quoted
This implements the Nokia vendor-specific communication device class function to exchange Phonet messages over USB. This function is already found in the "PC suite" USB profile of (non-Linux) Nokia handsets. Signed-off-by: Rémi Denis-Courmont <redacted> --- drivers/usb/gadget/f_phonet.c | 621 +++++++++++++++++++++++++++++++++++++++++ drivers/usb/gadget/u_phonet.h | 21 ++ 2 files changed, 642 insertions(+), 0 deletions(-) create mode 100644 drivers/usb/gadget/f_phonet.c create mode 100644 drivers/usb/gadget/u_phonet.hany reason why you didn't add an option to Kconfig to actually select this gadget?Yeah: this is NOT a gadget. This is a function for any gadget that wishes to use it. Same as the OBEX function in fact. What would be needed is a Kconfig for some gadget that actually uses that. A -slightly outdated- example is here: http://repository.maemo.org/pool/maemo5.0/free/k/kernel/
I see. Makes sense to me now. Any reason why the g_nokia gadget is not merged upstream? Would be nice to have this around for actually testing the PhoNet stuff. Regards Marcel