Thread (5 messages) 5 messages, 3 authors, 2009-01-06

Re: [PATCH] ibmveth: use consistent types

From: David Miller <davem@davemloft.net>
Date: 2008-12-31 05:50:03
Also in: linuxppc-dev

From: Stephen Rothwell <redacted>
Date: Wed, 31 Dec 2008 14:02:25 +1100
These variables are only used with an interface involving "unsigned
long" and the macros are only used with these variables.  This change
will prevent some warnings when we change u64 to "unsigned long long".

This code is only built for 64bit powerpc, so the transformation is
really a noop.

Signed-off-by: Stephen Rothwell <redacted>
I'd prefer if the types were to remain 32-bit portable.

Doing things like this is just a problem waiting to happen,
either for the first person who actually finds a need and
a way to use this driver on 32-bit or the person who cut and
pastes this code into their driver which should work on both
32-bit and 64-bit.

Patch not applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help