Re: [PATCH 03/27] drivers/net: fix sparse warning: returning void-valued expression
From: Hannes Eder <hidden>
Date: 2008-12-26 14:40:20
Also in:
kernel-janitors, lkml
From: Hannes Eder <hidden>
Date: 2008-12-26 14:40:20
Also in:
kernel-janitors, lkml
On Fri, Dec 26, 2008 at 1:17 AM, David Miller [off-list ref] wrote:
From: Hannes Eder <redacted> Date: Mon, 22 Dec 2008 20:15:17 +0100quoted
Fix this sparse warning: drivers/net/niu.c:8850:2: warning: returning void-valued expression Signed-off-by: Hannes Eder <redacted>Can we just fix sparse not to generate this warning? It's marginal, at best. C++ even explicitly defines this as valid and last time I brought this up Linus even agreed. The types match, the function returns void and it is returning a void, what is the problem?
after reading the following thread I decided to submit such type of patches: On Thu, 1 May 2008 at 13:53:39 +0100, Al Viro wrote:
On Thu, May 01, 2008 at 03:42:14PM +0300, Boaz Harrosh wrote:quoted
quoted
3. 6.8.6.4(1): A return statement with an expression shall not appear in a function whose return type is void.Please forgive my ignorance, where is this quote from?C99. I don't have C90 in front of me, so I can't give you exact quote from there, but it's been explicitly banned in C90 as well.
see http://lkml.org/lkml/2008/5/1/112