Thread (2 messages) 2 messages, 2 authors, 2008-12-24

Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-while a compound statement

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2008-12-24 02:10:48
Also in: kernel-janitors, lkml


On Wed, 24 Dec 2008, Krzysztof Halasa wrote:
People learn, or should, through the life :-)
Sure. But you should learn about the things that matter - not learn to 
avoid the stupid pitfalls that come from confusingly doing things so that 
they visually look similar even when they do different things.

So don't make people learn by putting traps in their face. That just 
wastes everybodys time.
I'm not sure being common or less common does matter here much.

OTOH I think it's pretty common. Approx as common as while (x) y is,
isn't it?
I doubt it. It certainly wasn't in the kernel. When we added the sparse 
warning, I think we got a couple of hits. 

Anyway,  not worth discussing. The fact is, the kernel does not accept do 
while without braces. I told you why. You can ignore it. I'll ignore you.

		Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help