Re: net-next: broken IP_PKTINFO
From: David Miller <davem@davemloft.net>
Date: 2008-12-18 06:17:17
From: David Miller <davem@davemloft.net>
Date: 2008-12-18 06:17:17
From: Eric Dumazet <redacted> Date: Thu, 18 Dec 2008 06:59:26 +0100
David Miller a écrit :quoted
Eric, we'll need to rever this change I think.I am afraid we have to revert it, yes.
Done.
About ip_cmsg_recv_pktinfo() : iif can be found in skb->iif instead of rt->rt_iif, but I am not sure about rt_spec_dst : Shouldnt we find it in ip_hdr(skb)->saddr ? Do you know if we really need rtable in ip_cmsg_recv_pktinfo() ?
I think we might, as these are routing attributes, which not necessarily match up with the values found in the SKB. In fact, I do remember that "specific destination" has a very exact definition in the routing RFCs and it has to do with the matched route. Conversely, in what situations (other than with the reverted patch applied, hehe) would the route not be attached here?