Re: [PATCH v2 4/5] fs: Introduce SINGLE dentries for pipes, socket, anon fd
From: Jörn Engel <hidden>
Date: 2008-11-29 10:38:36
Also in:
linux-fsdevel, lkml
On Sat, 29 November 2008 09:44:23 +0100, Eric Dumazet wrote:
quoted hunk
+struct dentry *d_alloc_single(const struct qstr *name, struct inode *inode) +{ + struct dentry *entry; + + entry = d_alloc(NULL, name); + if (entry) { + entry->d_sb = inode->i_sb; + entry->d_parent = entry; + entry->d_flags |= DCACHE_SINGLE | DCACHE_DISCONNECTED; + entry->d_inode = inode; + fsnotify_d_instantiate(entry, inode); + security_d_instantiate(entry, inode); + } + return entry;
Calling the struct dentry entry had me onfused a bit. I believe everyone else (including the code you removed) uses dentry.
quoted hunk
@@ -918,7 +906,7 @@ struct file *create_write_pipe(int flags) struct inode *inode; struct file *f; struct dentry *dentry; - struct qstr name = { .name = "" }; + static const struct qstr name = { .name = "" }; err = -ENFILE; inode = get_pipe_inode();
...
quoted hunk
@@ -371,20 +358,13 @@ static int sock_alloc_fd(struct file **filep, int flags) static int sock_attach_fd(struct socket *sock, struct file *file, int flags) { struct dentry *dentry; - struct qstr name = { .name = "" }; + static const struct qstr name = { .name = "" };
These two could even be combined. And of course I realize that I comment on absolute trivialities. On the whole, I couldn't spot a real problem in your patches. Jörn -- Public Domain - Free as in Beer General Public - Free as in Speech BSD License - Free as in Enterprise Shared Source - Free as in "Work will make you..."