* Joerg Roedel [off-list ref] wrote:
+ ret = ops->map_sg(hwdev, sg, nents, direction);
stray double space in '= ops'.
another very small detail:
+ unsigned long flags;
+ struct dma_debug_entry *entry;
+ struct scatterlist *s;
+ int i;
please order them like this, similar to the include line:
+ struct dma_debug_entry *entry;
+ struct scatterlist *s;
+ unsigned long flags;
+ int i;
that makes the whole variable section non-intrusive. (and also acts as
a patch-conflict-reducer mechanism in the future - when variable
definition lines get particularly long)
(not a hard rule, exceptions are possible - grouping same-type fields
together, etc.)
Ingo