Thread (62 messages) flat view 62 messages, 8 authors, 2009-07-02

Re: [PATCH 06/10] x86: add check code for map/unmap_sg code

From: Ingo Molnar <hidden>
Date: 2008-11-21 17:11:30
Also in: lkml

* Joerg Roedel [off-list ref] wrote:
+	ret =  ops->map_sg(hwdev, sg, nents, direction);
stray double space in '=  ops'.

another very small detail:
+	unsigned long flags;
+	struct dma_debug_entry *entry;
+	struct scatterlist *s;
+	int i;
please order them like this, similar to the include line:
+	struct dma_debug_entry *entry;
+	struct scatterlist *s;
+	unsigned long flags;
+	int i;
that makes the whole variable section non-intrusive. (and also acts as 
a patch-conflict-reducer mechanism in the future - when variable 
definition lines get particularly long)

(not a hard rule, exceptions are possible - grouping same-type fields 
together, etc.)

	Ingo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help