Thread (16 messages) 16 messages, 5 authors, 2009-12-28

Re: [PATCH] IPVS: Allow boot time change of hash size.

From: David Miller <davem@davemloft.net>
Date: 2008-11-27 07:37:59
Also in: lvs-devel

From: "Catalin(ux) M. BOIE" <redacted>
Date: Thu, 27 Nov 2008 00:05:50 -0700 (MST)
Do you mean that it should be computed based on memory size or you mean
that it should be changeable on-the-fly, even when we have some
connections in the tables already?
I mean the latter.  We do this in other subsystems, such as
IPSEC, for various hashes.
Do you have some hints (where to look for a similar thing)?
The thing that worries me a little is the locking around the move and
maybe the latency involved. Yes, of course you will not change it several
times per minute, but...
You only increase, never decrease.

A lock is held during every access to these hash tables, so
the locking should be very similar.

Have a look at xfrm_hash_resize() in net/xfrm/xfrm_state.c to get
a good idea on how this stuff can be done.  And hey, that code
resizes 3 tables at once, you only need to handle one :)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help