Re: [RFC] Validate ethtool autoneg before relaying
From: "Michael Chan" <mchan@broadcom.com>
Date: 2008-11-26 23:31:15
On Wed, 2008-11-26 at 14:17 -0800, Matt Carlson wrote:
quoted hunk ↗ jump to hunk
diff --git a/net/core/ethtool.c b/net/core/ethtool.c index 14ada53..6362f56 100644 --- a/net/core/ethtool.c +++ b/net/core/ethtool.c@@ -164,6 +164,9 @@ static int ethtool_set_settings(struct net_device *dev, void __user *useraddr) if (copy_from_user(&cmd, useraddr, sizeof(cmd))) return -EFAULT; + if (cmd.autoneg != AUTONEG_ENABLE && cmd.autoneg != AUTONEG_DISABLE) + return -EFAULT; +
Matt, you should return -EINVAL here instead.
return dev->ethtool_ops->set_settings(dev, &cmd); }