Thread (12 messages) 12 messages, 5 authors, 2008-11-26

Re: [PATCH] netdev: generate kobject uevent on network state transitions

From: Kay Sievers <hidden>
Date: 2008-11-26 12:09:37

On Wed, Nov 26, 2008 at 06:24, Marcel Holtmann [off-list ref] wrote:
quoted
quoted
quoted
quoted
It is easier for some applications to deal with text based interfaces
like uevent, rather than using netlink to listen for events.

Note, this does not deal with network namespaces but that is a generic
problem that already exists with kobjects (see rename events).

Signed-off-by: Stephen Hemminger <redacted>
...
quoted
quoted
do we wanna copy just what ifconfig shows or do we might be a more
intelligent and have separate variables like RUNNING=1 etc.?
Was arbitrary choice to just use same flags as existing ifconfig.
What ever feels best I guess...
So what do folks want me to do here?  Should I put Stephen's
latest patch in, or do we want to make some kind of flags change?
I am thinking of using per value variables. My personal choice.

Kay, any pointers or opinions from you?
As long as we can match values with fnmatch(), it should all work fine.

Bitmasks are fine if represented as binary strings, otherwise, like
for hex strings, the fnmatch() looks really weird.

As long as no string value in the list is contained in another value,
like matching for RUNNING, IS_RUNNING, RUNNING2 would be, it's fine to
stuff them all in one string just separated by comma. If they can ever
overlap, we would need to add the comma also to the beginning and end
of the string, to be able to put it into the match string like
"*,RUNNING,*", to avoid wrong matches by partial string matches.

I leave it up to you, I'm fighting with really weird things in some
other subsystems, so all of the possible options here for the net
events look pretty to me, and should work fine, compared to some stuff
I'm used to. :)

Thanks,
Kay
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help