Re: netfilter 01/03: ctnetlink: fix conntrack creation race
From: David Miller <davem@davemloft.net>
Date: 2008-11-25 00:05:47
Also in:
netfilter-devel
From: Patrick McHardy <redacted> Date: Mon, 24 Nov 2008 14:44:36 +0100 (MET)
netfilter: ctnetlink: fix conntrack creation race
Conntrack creation through ctnetlink has two races:
- the timer may expire and free the conntrack concurrently, causing an
invalid memory access when attempting to put it in the hash tables
- an identical conntrack entry may be created in the packet processing
path in the time between the lookup and hash insertion
Hold the conntrack lock between the lookup and insertion to avoid this.
Reported-by: Zoltan Borbely [off-list ref]
Signed-off-by: Patrick McHardy [off-list ref]Applied.