Re: [PATCH netdev-2.6] jme: JMicron Gigabit Ethernet Driver
From: David Miller <davem@davemloft.net>
Date: 2008-11-21 08:46:33
From: David Miller <davem@davemloft.net>
Date: 2008-11-21 08:46:33
From: Stephen Hemminger <redacted> Date: Thu, 20 Nov 2008 22:45:42 -0800
On Thu, 20 Nov 2008 21:36:27 -0800 (PST) David Miller [off-list ref] wrote:quoted
From: Stephen Hemminger <redacted> Date: Thu, 20 Nov 2008 21:20:45 -0800quoted
6. Not using pci dma allocation which is more standard conventionUsing the generic DMA interfaces is actually preferred. There is no effective difference other than using a more generic interface.Ok, but this???
Yes, of course, all of those NAPI et al. abstraction macros have to go. I was only commenting about the DMA bits, the rest of your criticism was on target.