Re: [PATCH 1/2] sch_netem: Remove classful functionality
From: David Miller <davem@davemloft.net>
Date: 2008-11-02 07:37:25
From: David Miller <davem@davemloft.net>
Date: 2008-11-02 07:37:25
From: Jarek Poplawski <redacted> Date: Fri, 31 Oct 2008 13:20:10 +0000
Patrick McHardy noticed that: "a lot of the functionality of netem requires the inner tfifo anyways and rate-limiting is usually done on top of netem. So I would suggest so either hard-wire the tfifo qdisc or at least make the assumption that inner qdiscs are work-conserving.", and later: "- a lot of other qdiscs still don't work as inner qdiscs of netem [...]". So, according to his suggestion, this patch removes classful options of netem. The main reason of this change is to remove ops->requeue() method, which is currently used only by netem. Signed-off-by: Jarek Poplawski <redacted>
Jarek, I applied this patch and your second one to net-next-2.6 But I did this only because I trust that you will address Stephen's feedback wrt. making existing netem functionality available in some way. Otherwise I'll have to revert these changes. Thanks!